Make SomeModel._default_manager return a BaseManager[SomeModel] instead of BaseManager[Model] #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
Jan 14, 2022
django-stubs/utils/functional.pyi
Outdated
| class classproperty(Generic[_Get]): | ||
| fget: Optional[Callable[[Type[_Self]], _Get]] = ... | ||
| def __init__(self, method: Optional[Callable[[Type[_Self]], _Get]] = ...) -> None: ... | ||
| def __get__(self, instance: Any, cls: Type[_Self] = ...) -> _Get: ... |
There was a problem hiding this comment.
From what I see __get__ is usually an overload of two functions.
You can take a look here: https://github.com/python/typeshed/
| @@ -48,7 +48,7 @@ | |||
| class Base(Generic[_T]): | |||
| def __init__(self, model_cls: Type[_T]): | |||
| self.model_cls = model_cls | |||
| reveal_type(self.model_cls._default_manager) # N: Revealed type is "django.db.models.manager.BaseManager[django.db.models.base.Model]" | |||
| reveal_type(self.model_cls._default_manager) # N: Revealed type is "django.db.models.manager.BaseManager[_T`1]" | |||
There was a problem hiding this comment.
Let's also test ._base_manager of some Model, so we can ensure that _T is correct.
There was a problem hiding this comment.
I'm super unfamiliar with these types of tests. I hope the new test makes sense!
|
I'm using pylance and found this does not work. user: Users = Users._default_manager.get(pk=user_id)shows error:
any ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the type annotations for _default_manager (and _base_manager) such that the returned manager's model is the specific model the manager belongs to instead of django.db.models.base.Model